Conversation
In test/development mode, don't flood the console with queries. Update mariaDb version to match production. In the devbox, we want deprecations to fail the pipeline. In Github, we don't want that, as dependabot updates or small package udates should not cause the build to fail. We will handle the deprecations once a developer works on the project. Add a separate deprecation.log in development mode.
Surfnet\StepupMiddleware\CommandHandlingBundle\Root\Command\FooBarCommand::$snakeCase is deprecated
MagicClosureTwigExtensionToNativeMethodsRector + attribute rules.
Prior to this change, organised imports was not enforced, but required by coding guidelines. This would result in PR feedback about unused imports, usage of fqn in code, etc. This change auto fixes & enforces correct import usage via phpcs / phpcbf.
…rTypeDeclarationSQL
…ations to attributes for everything.
…sons. Only except camelcase method names and line lenghts.
RecastingRemovalRector
… is accessible by default now. RemoveReflectionSetAccessibleCallsRector
…nRector, NullToStrictStringFuncCallArgRector, FunctionFirstClassCallableRector
Tests cannot be abstract. So PHPunit does not allow it to end on 'Test' anymore.
Math is no longer needed as an explicit dependency.
xss_protection is deprecated. The recommended unsafe-inline al not allowed.
twigphp/Twig@7c38fc2 Disable doctrine automapping deprecation warning.
GetFiltersToAsTwigFilterAttributeRector InvokableCommandInputAttributeRector
…ds on it. Running `./bin/console` produces an error without it as jms/translation-bundle tries to instatiate it.
…ble in the cli, because they were not autoconfigured. This change ensures they are registered by adding autoconfigure to the console_commands.yml service definition. And adds a test to validate that. And adds autoconfigure to all other service definitions to ensure all attribute services can be picked up.
MKodde
reviewed
Dec 1, 2025
Member
MKodde
left a comment
There was a problem hiding this comment.
Enjoy some nitpicks, questions and concerns...
77a29d3 to
9e949fa
Compare
fe4cee2 to
a862c16
Compare
a862c16 to
cab9488
Compare
MKodde
reviewed
Dec 4, 2025
MKodde
approved these changes
Dec 4, 2025
… doctrine bundle. Instead, set the commented via the custom type. doctrine/DoctrineBundle#977
Relying on the default column size for varchar fields is deprecated. This change configures all varchar custom types to rely on the previous default value of 255, if not overridden. See \Doctrine\DBAL\Platforms\AbstractPlatform::getVarcharDefaultLength See doctrine/dbal#3263
Prior to this change, deprecation warnings about safepoints were thrown. This change enables safepoints for all connections. Safepoints are not supported by myisam tables or drivers like sqlite. doctrine/dbal#6272
$request->get is deprecated. $request->query->get for URL parameters or $request->request->get for POST should be used instead. See https://symfony.com/blog/new-in-symfony-7-4-request-class-improvements Phpstan: Fix get parameter types Prior to this change, \Surfnet\StepupMiddleware\ApiBundle\Controller\RaCandidateController::search could receive `secondFactorTypes`, which could never be an array, yet the query expects an array. This change ensures the query parameters for this property are read sa an array read.
… UpdateIdentityCommand Prior to this change, `Deprecated: Creation of dynamic property` was logged when running the behat tests in devconf. This can be caused when properties are set in old events, that are later removed from the class. We could check in the CommandValueResolver whether a field exists before setting it, but that carries more risk, in case the properties might be still read dynamically somewhere.
cab9488 to
95fe6a3
Compare
Contributor
Author
|
Thanks @MKodde Good points about the autoloader and component_info. I did a final review and did some small fixes and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.